Opened on 06/28/2016 at 10:35:13 AM
Closed on 07/18/2016 at 06:13:19 PM
#4201 closed defect (fixed)
CSS property filter still applied when ABP is disabled everywhere
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | trev, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Windows 10 Pro
Firefox 47
ABP 2.7.3.4184
How to reproduce
- Add this custom filter: testpages.adblockplus.org##[-abp-properties='width: 64px;']
- Go to https://testpages.adblockplus.org/
- Notice the ABP logo is being hidden by this filter
- Disable ABP everywhere via the context menu
- Refresh the page
Observed behaviour
The custom filter is still being applied.
Expected behaviour
ABP shouldn't apply any filters when it's disabled.
It's working fine if you disable ABP for this particular domain only.
Attachments (0)
Change History (7)
comment:1 Changed on 06/28/2016 at 04:37:20 PM by mapx
- Cc mapx added
comment:2 Changed on 07/18/2016 at 03:48:22 PM by trev
- Priority changed from Unknown to P1
- Ready set
comment:3 Changed on 07/18/2016 at 03:50:01 PM by trev
- Component changed from Adblock-Plus-for-Firefox to Core
- Owner set to trev
comment:4 Changed on 07/18/2016 at 03:50:54 PM by trev
- Component changed from Core to User-Interface
comment:5 Changed on 07/18/2016 at 03:53:45 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 07/18/2016 at 06:09:45 PM by abpbot
A commit referencing this issue has landed:
Issue 4201 - CSS property filter still applied when ABP is disabled everywhere
Note: See
TracTickets for help on using
tickets.
Actually, the problematic code is in the adblockplusui repository (messageResponder.js) so technically this is UI...