Opened on 05/03/2014 at 09:40:26 PM
Closed on 11/10/2017 at 11:17:30 AM
#421 closed defect (rejected)
(abpwatcher) Ctrl != Accel on Mac
| Reported by: | barbaz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Mac OS X
Firefox or SeaMonkey with ABP installed
latest version of Diagnostics for Adblock Plus
How to reproduce
Install the latest Diagnostics for Adblock Plus on Firefox or SeaMonkey on Mac OS X.
Observed behaviour
The keyboard shortcut assigned to start Diagnostics for Adblock Plus is Ctrl-Shift-F4 despite about:config -> extensions.abpwatcher.startwatching_key having its default value of
Accel Shift M, Accel Shift F4
Unfortunately Ctrl-Shift-F4 is also a default system hotkey on this Mac, making it awkward to start Diagnostics via the keyboard.
This has already been fixed by https://hg.adblockplus.org/buildtools/rev/aea164a0381d; the issue here is that Diagnostics for Adblock Plus does not contain that fix.
Expected behaviour
The default keyboard shortcut to start Diagnostics for Adblock Plus should be Command-Shift-F4, which would not conflict with system hotkeys.
Attachments (0)
Change History (3)
comment:1 Changed on 05/13/2014 at 01:18:59 AM by barbaz
comment:2 Changed on 07/09/2014 at 12:38:11 PM by philll
- Platform set to Firefox
comment:3 Changed on 11/10/2017 at 11:17:30 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.
Seems fixed in Diagnostics 1.2.5a.222, thank you.