Opened on 06/30/2016 at 01:03:28 PM
Closed on 07/18/2016 at 06:08:21 PM
Last modified on 09/09/2016 at 05:53:36 AM
#4211 closed defect (fixed)
Element hiding doesn't work under certain conditions
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev | Blocked By: | #4251 |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Windows 10 Pro
ABP 2.7.3.4186
EasyList
Tested with Firefox 47.0.1, 48 Beta 4 and latest Nightly
How to reproduce
- Go to https://www.rt.com/op-edge/345470-nsa-leaks-snowden-whistleblower/ and scroll down to the first embedded YouTube video
- Click on it's title "Snowden leaks lead to legal reforms, not just public awareness"
Observed behaviour
While element hiding seems to work fine on rt.com, on YouTube it doesn't. You can see the advertising label in the right sidebar at the top and the yellow mark at the beginning of the seek bar. Those two elements are usually hidden in EasyList.
Expected behaviour
The two elements shouldn't be visible.
Background
This is similar to #4243. While we don't get an exception here, the page's URL is reported as about:blank - it isn't really initialized when we look at it.
Attachments (0)
Change History (7)
comment:1 Changed on 07/18/2016 at 01:30:49 PM by trev
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 07/18/2016 at 01:59:17 PM by trev
- Description modified (diff)
- Owner set to trev
comment:3 Changed on 07/18/2016 at 02:01:06 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/18/2016 at 06:07:37 PM by abpbot
comment:5 Changed on 07/18/2016 at 06:08:21 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 07/19/2016 at 01:37:21 PM by trev
- Blocked By 4251 added
comment:7 Changed on 09/09/2016 at 05:53:36 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Element hiding looks to be working as expected in general and with the steps/example above.
ABP 2.7.3.4198-beta
Firefox 38 / 48 / Windows 7
Nightly 51.0a1 / Windows 7
A commit referencing this issue has landed:
Issue 4211 - Improve detection of uninitialized documents for means of element hiding