Opened on 07/06/2016 at 01:36:26 PM
Closed on 07/06/2016 at 05:11:51 PM
Last modified on 10/20/2016 at 02:22:14 PM
#4230 closed defect (fixed)
$generichide is apparently whitelisting site-specific hiding filters as well
Reported by: | arthur | Assignee: | trev |
---|---|---|---|
Priority: | P1 | Milestone: | Adblock-Plus-2.8-for-Firefox |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | trev | Blocked By: | |
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description
Environment
Windows 10 Pro
Firefox 47.0, 48.0 Beta 5 and Nightly (20160706030233)
ABP 2.7.3.4189
How to reproduce
- Add this custom filter adblockplus.org###main
- Go to https://adblockplus.org/
- Notice the missing content
- Add this custom exception rule @@||adblockplus.org^$generichide
- Go to https://adblockplus.org/
Observed behaviour
Missing content is back, adblockplus.org###main seems to be whitelisted by @@||adblockplus.org^$generichide.
Expected behaviour
Since adblockplus.org###main is a site-specific filter, it should still hide the DIV.
Attachments (0)
Change History (5)
comment:1 Changed on 07/06/2016 at 01:56:37 PM by trev
- Owner set to trev
- Ready set
comment:2 Changed on 07/06/2016 at 01:56:52 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 07/06/2016 at 05:10:59 PM by abpbot
comment:4 Changed on 07/06/2016 at 05:11:51 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Priority changed from Unknown to P1
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 10/20/2016 at 02:22:14 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 2.7.3.4214-beta
Firefox 38 / 46 / 49 / Windows 7
Firefox Nightly 52.0a1 (2016-10-20) / Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4230 - Don't disable element hiding if a generichide exception rule is present