Opened on 07/12/2016 at 03:41:15 PM
Closed on 09/14/2016 at 09:49:53 AM
#4239 closed change (fixed)
Change indentation to reflect our coding style
| Reported by: | rjeschke | Assignee: | asmirnov |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We do use two-space indentation for Java and C++ source files.
What to change
Correct the indentation in all necessary files.
Attachments (0)
Change History (5)
comment:1 Changed on 07/13/2016 at 07:48:50 AM by asmirnov
comment:2 Changed on 07/18/2016 at 09:47:00 AM by rjeschke
It is two spaces, we use two spaces nearly everywhere here. Either this was not corrected in the beginning by us, or the coding style was changed by Mozilla. We will need to update our coding style guide and remove the links to Mozilla's.
comment:3 Changed on 08/02/2016 at 10:46:05 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 09/14/2016 at 09:48:45 AM by abpbot
A commit referencing this issue has landed:
Issue 4239 - Change indentation to reflect our coding style
comment:5 Changed on 09/14/2016 at 09:49:53 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Probably i've missed something:
https://adblockplus.org/en/coding-style "Follow the Mozilla Coding Style's Java practices"
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Java_practices "4-space indents"
should they be 2 or 4 spaces eventually?