Opened on 05/05/2014 at 06:57:22 AM

Closed on 05/05/2014 at 04:17:12 PM

Last modified on 05/09/2014 at 06:17:41 AM

#424 closed defect (fixed)

Adblock Warning Removal List disabling itself

Reported by: Crits Assignee: greiner
Priority: P1 Milestone: Adblock-Plus-2.6.1-for-Firefox
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5198627827875840/
​http://codereview.adblockplus.org/6324527734718464/

Description (last modified by greiner)

Environment

Windows 7 SP1 x64
Firefox 29.0
Adblock Plus 2.6.0.3805

How to reproduce

  1. Have the Adblock Warning Removal List activated
  2. Update ABP

Observed behaviour

The Adblock Warning Removal List is no longer active.
At least one other user is experiencing that: ​https://adblockplus.org/forum/viewtopic.php?t=22528

Expected behaviour

The list should be kept activated.

Attachments (0)

Change History (9)

comment:1 Changed on 05/05/2014 at 11:53:08 AM by mikhaelkh

It happens after ABP update.

comment:2 Changed on 05/05/2014 at 01:39:00 PM by philll

  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed on 05/05/2014 at 01:47:10 PM by philll

  • Description modified (diff)

comment:4 Changed on 05/05/2014 at 01:57:36 PM by greiner

  • Component changed from Adblock-Plus-for-Firefox to Core
  • Description modified (diff)
  • Owner set to greiner

I was able to reproduce this on Chrome as well due to it being caused by shared logic.

Last edited on 05/05/2014 at 02:28:02 PM by greiner

comment:5 Changed on 05/05/2014 at 02:36:31 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 05/05/2014 at 03:23:34 PM by trev

  • Cc trev added

comment:7 Changed on 05/05/2014 at 04:17:12 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed:
​https://hg.adblockplus.org/adblockplus/rev/485930127649
​https://hg.adblockplus.org/adblockpluschrome/rev/79b53c28fead

comment:8 Changed on 05/05/2014 at 05:59:30 PM by Crits

Wow, that was fast!

comment:9 Changed on 05/09/2014 at 06:17:41 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.