Opened on 07/18/2016 at 10:13:24 AM

Last modified on 10/06/2017 at 11:33:29 AM

#4248 reviewing change

Add codestyle check

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: rjeschke, diegocarloslima Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29347926/
​https://codereview.adblockplus.org/29567648/

Description

Background

Since we are open-source we need to pay attention to our code style. Having a mechanism to automagically check the coding style is a valuable tool for us.

What to change

Use checkstyle ant plugin (​http://checkstyle.sourceforge.net/anttask.html) to perform codestyle checkings automatically. We could use this for another projects to have consistent style across the projects (both java and android). Current code style is described at ​https://adblockplus.org/en/coding-style.

Attachments (0)

Change History (2)

comment:1 Changed on 07/18/2016 at 12:52:25 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/06/2017 at 11:33:29 AM by asmirnov

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from asmirnov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.