Opened on 07/20/2016 at 10:44:20 AM
Closed on 07/21/2016 at 04:16:11 PM
Last modified on 07/26/2016 at 09:13:13 AM
#4255 closed change (fixed)
Place Element Hiding Helper button in the DevTools toolbar if one exists
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.3.9 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Element Hiding Helper will currently insert its button before the breadcrumbs in the Inspector panel. However, in Firefox 48 the breadcrumbs were moved to the bottom, and now we have element overlapping issues.
What to change
Move the icon back to the main toolbar, insert it after the "Create New Node" button which was also added in Firefox 48. Keep the original logic for older Firefox versions.
Attachments (0)
Change History (4)
comment:1 Changed on 07/20/2016 at 10:52:08 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 07/21/2016 at 04:15:21 PM by abpbot
comment:3 Changed on 07/21/2016 at 04:16:11 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 07/26/2016 at 09:13:13 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- In Firefox 47 and below the ABP icon in Inspect Element remains in front of the breadcrumbs toolbar.
- In Firefox 48 and up, the ABP icon sits just after the '+' icon (Create a new node). As stated above, the breadcrumbs toolbar now sits at the bottom of the inspector.
Version 1.3.8.536-beta
Firefox: (38, 42, 47) - (48.0b10 Beta, 49.0a2 - Development, 50.0a1 - Nightly)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4255 - Place Element Hiding Helper button in the DevTools toolbar if one exists