Opened on 07/26/2016 at 04:40:00 PM
Closed on 05/19/2017 at 10:33:58 AM
#4264 closed change (fixed)
Handle actions in a more centralized way
| Reported by: | greiner | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | a11y, new-settings-page |
| Cc: | saroyanm | Blocked By: | |
| Blocking: | #5158 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
To stop any further and reduce existing code duplication we should centralize the execution of UI actions used in the global handlers for "keyup" and "click" events.
What to change
- Centralize execution of actions such as "open-doclink" and use it in the global handlers for the "keyup" and "click" events.
- When a link is focused and the Enter key is pressed it should execute all actions that are assigned to it.
Attachments (0)
Change History (9)
comment:1 Changed on 07/26/2016 at 04:43:14 PM by greiner
- Owner set to greiner
comment:2 Changed on 01/24/2017 at 10:28:05 AM by saroyanm
- Description modified (diff)
- Keywords new-settings-page added
comment:3 Changed on 01/24/2017 at 12:00:39 PM by saroyanm
- Cc saroyanm added
comment:4 Changed on 01/24/2017 at 03:40:16 PM by saroyanm
- Owner changed from greiner to saroyanm
comment:5 Changed on 01/24/2017 at 04:45:13 PM by greiner
- Description modified (diff)
- Summary changed from Make sure to include all links in tab order in new options page to Handle actions in a more centralized way
comment:6 Changed on 01/27/2017 at 01:30:39 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 04/21/2017 at 09:53:17 AM by wspee
- Blocking 5158 added; 2407 removed
As this will still be implemented in the new new options page I changed it to block #5158 instead.
comment:8 Changed on 05/19/2017 at 10:33:06 AM by abpbot
A commit referencing this issue has landed:
issue 4264 - centralize action handling
comment:9 Changed on 05/19/2017 at 10:33:58 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
@greiner I've updated the ticket as we discussed together, I noticed that the ticket is assigned to you. Can you please remove assignment if you are not working/planing to work in near future.