Opened on 08/10/2016 at 01:32:14 PM
Closed on 08/10/2016 at 05:37:27 PM
Last modified on 08/10/2016 at 05:37:49 PM
#4318 closed change (fixed)
Prohibit Hockeyapp 4.x from calling home on every app start
| Reported by: | pavelz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-iOS-1.5.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Hockeyapp SDK since version 4.x is by default generating "usage metric". It can be custom events, and even if there are no such, there is at least one event which is the app start. This was identified as build upload duplication - because the metric is attached to a "ghost" build upload entry, even if there is no later real upload.
https://support.hockeyapp.net/discussions/problems/60279-ios-uploads-duplicated-with-a-zero-size-ghost
https://www.pivotaltracker.com/story/show/127067897
What to change
Prohibit HA SDK from sending ANY usage metric at all via
https://www.hockeyapp.net/help/sdk/ios/4.0.1/Classes/BITHockeyManager.html#//api/name/disableMetricsManager
Attachments (0)
Change History (3)
comment:1 Changed on 08/10/2016 at 01:40:59 PM by pavelz
comment:2 Changed on 08/10/2016 at 01:41:10 PM by pavelz
- Ready set
comment:3 Changed on 08/10/2016 at 05:37:27 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
Cannot be QAd directly. Indirect QA is that the build resulting from this patch
https://circleci.com/gh/kitt-browser/adblockplus-ios/1108
appears only in the primary uploading HA channel of Eyeo
https://rink.hockeyapp.net/manage/apps/185237/app_versions/97
and not the defaulting HA channel of Salsita
https://rink.hockeyapp.net/manage/apps/197999
which was the sign of build duplication issue
https://www.pivotaltracker.com/story/show/127067897
Simpler said, the fact that there is no build ghost anywhere, means that HA is not sending any metrics.
https://www.pivotaltracker.com/story/show/128064665