Opened on 08/25/2016 at 02:29:19 PM
Closed on 09/13/2016 at 07:00:27 PM
Last modified on 10/25/2016 at 04:02:24 AM
#4364 closed change (fixed)
Drop support for Chrome 29-40 and remove legacy code
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Currently, Adblock Plus supports Chrome 29 trough the latest version (i.e. 54 dev). Testing all those versions became virtually impossible. Moreover, we have a couple workarounds for older versions, we'd like to get rid of. Also considering the low users numbers for Chrome 29-40 (including other Chromium based browsers), i.e. 0.7% of Adblock Plus users on Chromium-based browsers, we decided to unsupport those versions and remove the legacy code.
What to change
- Advance minimum_chrome_version to 41.0
- Remove workaround to detect top-level documents on Chrome 29.
- Remove workaround dealing with anonymous frames on Chrome <=40 and get rid of the init() function. Refactoring the element hiding code into a class seems sensible.
Attachments (0)
Change History (5)
comment:1 Changed on 08/25/2016 at 03:11:04 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/13/2016 at 06:59:13 PM by abpbot
comment:4 Changed on 09/13/2016 at 07:00:27 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 10/25/2016 at 04:02:24 AM by rraceanu
- Verified working set
No longer able to install ABP on Chrome <41, User will receive the message "Package is invalid. Details: This extension requires Google Chrome version 41.0 or greater", verified on ABP version 1.12.2.1670, Chrome 39.
A commit referencing this issue has landed:
Issue 4364 - Drop support for Chrome 29-40 and remove legacy code