Opened on 08/25/2016 at 06:32:54 PM
Closed on 04/11/2017 at 11:22:43 AM
#4367 closed change (fixed)
Update Eyeo address in sitescripts templates
| Reported by: | kvas | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | saroyanm, annlee@…, jnink | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by jnink)
Background
A couple of templates used by the scripts in sitescripts have the physical address of Eyeo in them (they were added in the process of implementing #2857). Assuming it makes sense to have it there, we should update it to the new address since we've moved.
What to change
Update the following two templates:
- send_installation_link/template/adblockbrowser_installation_link.tmpl,
- submit_email/template/edge_verification.mail
Replace the address:
Im Klapperhof 7-23 50670 Cologne, Germany
with the new address:
Lichtstraße 25 50825 Cologne Germany
While we're at it, we should probably also update the managing directors to "Till Faida, Felix Dahlke & Steffen Kiedel" as in the signature.
Attachments (0)
Change History (12)
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed on 08/29/2016 at 03:37:51 PM by saroyanm
- Cc annlee@… jnink added
Replying to kvas:
@saroyanm: Since you're the one who requested the original functionality to be created, I'll ask you: Do you think that our physical address is necessary in these templates? If so, do you think we should add our Berlin address to it?
Regarding #2857 as far as I remember @Ann-Lee provided me the initial template, but I think it's a legal question and not sure if the emails of employees also need to list both addresses, What you think @Judith ?
comment:3 in reply to: ↑ 2 Changed on 08/29/2016 at 04:01:47 PM by jnink
Replying to saroyanm:
Replying to kvas:
@saroyanm: Since you're the one who requested the original functionality to be created, I'll ask you: Do you think that our physical address is necessary in these templates? If so, do you think we should add our Berlin address to it?
Regarding #2857 as far as I remember @Ann-Lee provided me the initial template, but I think it's a legal question and not sure if the emails of employees also need to list both addresses, What you think @Judith ?
Yes, address is necessary according to German laws. Berlin office is not necessary. Headquarter, which is Cologne, is sufficient.
comment:4 Changed on 08/29/2016 at 05:33:48 PM by kvas
- Priority changed from Unknown to P3
- Ready set
Thank you, Manvel and Judith, it's now clear.
comment:5 Changed on 01/11/2017 at 01:39:51 PM by jsonesen
- Owner set to jsonesen
comment:6 follow-up: ↓ 10 Changed on 01/11/2017 at 06:47:13 PM by jsonesen
should the the capitalization of "Eyeo" be changed to lower case as well?
comment:9 Changed on 04/11/2017 at 10:48:29 AM by jnink
Also added Steffen as a managing director.
comment:10 in reply to: ↑ 6 Changed on 04/11/2017 at 10:48:51 AM by jnink
Replying to jsonesen:
should the the capitalization of "Eyeo" be changed to lower case as well?
Yes please.
comment:11 Changed on 04/11/2017 at 11:21:22 AM by abpbot
A commit referencing this issue has landed:
Issue 4367 - Updates eyeo address in templates
comment:12 Changed on 04/11/2017 at 11:22:43 AM by jsonesen
- Resolution set to fixed
- Status changed from new to closed
@saroyanm: Since you're the one who requested the original functionality to be created, I'll ask you: Do you think that our physical address is necessary in these templates? If so, do you think we should add our Berlin address to it?