Opened on 08/31/2016 at 04:03:26 PM

Closed on 09/01/2016 at 11:05:00 AM

#4388 closed change (fixed)

[hgreview] Reviews should use Base URL field in order to indicate the repository

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29350365/

Description

Background

hg review will currently add the repository to the issue description. Apparently, Rietveld has a Base URL field for that very purpose which is currently being left blank.

What to change

Specify --base_url parameter when uploading instead of modifying the description.

Attachments (0)

Change History (3)

comment:1 Changed on 08/31/2016 at 04:05:42 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/01/2016 at 11:04:37 AM by abpbot

A commit referencing this issue has landed:
​Issue 4388 - [hgreview Reviews should use Base URL field in order to indicate the repository]

comment:3 Changed on 09/01/2016 at 11:05:00 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.