Opened on 09/09/2016 at 09:33:28 AM
Last modified on 10/06/2016 at 02:31:47 PM
#4400 reopened change
Display ABP extension version in About page
| Reported by: | pavelz | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Browser-for-iOS | Keywords: | blocked |
| Cc: | mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://bitbucket.org/pavel-zdenek/adblockplusadblockbrowserios/pull-requests/2 |
||
Description (last modified by mario)
Background
As the ABP extension dependency updates are becoming more frequent (and it rightfully be so) there is a danger of not knowing which version is being executed in the current ABB build. A decision was made in the dawn of ABB that an extension update will always happen in scope of ABB update. Which means that a (possible) extension update is checked only if there is ABB version bump. However, an extension update is always made as part of new ABB develop branch evolution, so a single develop version can potentially exist with multiple extension versions. Any existing develop build must be remembered to delete and clean new build installation ensured, which is extremely error prone. Verifying an extension version at runtime is impossible on real device and still technically challenging even on simulator.
What to change
In ABB's "About" page (ABB -> main menu -> Settings -> About)...
- change the first headline from VERSION to ADBLOCK BROWSER VERSION,
- add a new headline called ADBLOCK PLUS VERSION,
- add a new list item below this headline containing the extensions version string
as shown in this screenshot.
For these changes use the standard iOS components, colors, fonts and style as already present.
Attachments (1)
Change History (17)
comment:1 Changed on 09/09/2016 at 09:34:18 AM by pavelz
comment:3 Changed on 09/12/2016 at 10:01:07 AM by mario
- Summary changed from Display ABP extension version in devbuild options to Display ABP extension version in About page
Changed on 09/12/2016 at 10:01:46 AM by mario
comment:4 Changed on 09/12/2016 at 10:02:19 AM by mario
- Description modified (diff)
- Priority changed from Unknown to P3
comment:5 Changed on 09/12/2016 at 12:00:20 PM by mario
@pavelz, as discussed, you can send a PR for adblockplusadblockbrowserios if you need to introduce changes to the api.js.
comment:6 Changed on 09/13/2016 at 09:04:01 AM by pavelz
If i play an average user, the proposed labelling appears confusing. The two labels are long and very similar. I wouldn't know what is the difference and may even report the wrong one if ever asked to tell one or the other. What about "BROWSER VERSION" and "ADBLOCK VERSION" ? Or is there any branding requirement to say explicitly "ADBLOCK PLUS VERSION" ?
comment:7 Changed on 09/13/2016 at 11:10:52 AM by pavelz
comment:8 Changed on 09/13/2016 at 11:12:56 AM by pavelz
Meanwhile ABB will be built and tested with a rigged extension, which is a release version 1.12.2.1645 with the pull request patch applied and the version changed to 1.12.2.4400 to be recognizable
comment:9 Changed on 09/13/2016 at 11:40:45 AM by pavelz
- Resolution set to fixed
- Status changed from new to closed
comment:10 Changed on 09/22/2016 at 07:10:06 AM by pavelz
Partially and temporarily rolled back by #4456
comment:11 Changed on 09/22/2016 at 01:34:05 PM by mario
- Milestone set to Adblock-Browser-for-iOS-1.5.1
Added to Milestone 1.5.1
comment:12 Changed on 09/29/2016 at 06:42:37 AM by scheer
- Please see #4456.
comment:13 Changed on 10/06/2016 at 10:15:24 AM by pavelz
- Resolution fixed deleted
- Status changed from closed to reopened
#4456 is public, reopening. Blocked by review of pull request https://issues.adblockplus.org/ticket/4400#comment:7
comment:14 Changed on 10/06/2016 at 10:17:43 AM by pavelz
- Milestone Adblock-Browser-for-iOS-1.5.1 deleted
comment:15 Changed on 10/06/2016 at 10:18:20 AM by pavelz
- Keywords blocked added
comment:16 Changed on 10/06/2016 at 02:31:47 PM by mario
- Review URL(s) modified (diff)
@mario let me know how do i go about changing api.js officially