Opened on 09/12/2016 at 10:42:52 AM

Closed on 09/14/2016 at 10:58:06 AM

#4410 closed change (fixed)

Update runserver.spec for new pyinstaller versions

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29352640/

Description

Background

New pyinstaller versions renamed the global WORKPATH symbol into workpath. Also, our hiddenimports hack seems to be unnecessary.

What to change

Remove the unnecessary hack to support hidden imports.

Attachments (0)

Change History (3)

comment:1 Changed on 09/12/2016 at 10:44:27 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/14/2016 at 10:57:24 AM by abpbot

A commit referencing this issue has landed:
​Issue 4410 - Update runserver.spec for new pyinstaller versions

comment:3 Changed on 09/14/2016 at 10:58:06 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.