Opened on 05/07/2014 at 04:23:17 PM
Closed on 11/06/2015 at 08:05:21 PM
Last modified on 01/05/2016 at 11:16:21 AM
#443 closed defect (fixed)
Popups aren't blocked anymore when blocking the URL it redirects to
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | smultron45@gmail.com, trev, manvel@adblockplus.org | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Firefox 29
ABP 2.6.0.3807
EasyList
Windows 8.1 Pro x64 Update 1
How to reproduce
- Go to http://slickvid.com/gwush16s7drt
- Click on the white background
Observed behaviour
A popup/popunder appears without redirecting to the ad URL (http://cdn.directrev.com/js/direct?s=S0002219 in my case) because it is blocked by
||directrev.com^$popup,third-party
The popup/popunder isn't blocked/closed though.
Expected behaviour
Not exactly sure when this changed but ABP blocked popups even if the immediate pop-up URL isn't blocked but the subsequent one(s).
Attachments (0)
Change History (13)
comment:1 Changed on 05/07/2014 at 06:58:32 PM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 05/08/2014 at 06:56:08 AM by mapx
comment:3 Changed on 05/08/2014 at 07:16:17 AM by trev
- Cc trev added
comment:4 Changed on 05/08/2014 at 07:36:26 AM by arthur
@mapx
Yes, this works as expected. However, popups were still closed/blocked before even if it's not the very first popup URL that is blocked.
comment:5 Changed on 05/08/2014 at 07:59:07 AM by philll
- Priority changed from P3 to P2
I'm wondering, whether we should set any bugs of kinda-core functionality to lower than P2
comment:6 Changed on 07/05/2014 at 03:19:32 AM by saroyanm
- Cc manvel@adblockplus.org added
- Platform set to Unknown
comment:7 Changed on 07/09/2014 at 12:38:11 PM by philll
- Platform changed from Unknown to Firefox
comment:8 Changed on 10/23/2015 at 02:56:34 PM by trev
- Blocked By 3208 added
- Tester set to Unknown
Will be fixed as side-effect of #3208.
comment:9 Changed on 10/26/2015 at 08:28:43 PM by trev
- Owner set to trev
comment:10 Changed on 10/26/2015 at 08:29:05 PM by trev
- Blocked By 3208 removed
- Review URL(s) modified (diff)
- Status changed from new to reviewing
Fixed in a separate commit after all.
comment:11 Changed on 11/06/2015 at 08:05:21 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 12/09/2015 at 02:29:00 PM by Ross
I've tried 10+ SlickVid URL's and they are all 404/video not found, and those pages don't appear to push any advertising/popups. Does anyone have a working URL?
comment:13 Changed on 01/05/2016 at 11:16:21 AM by arthur
I think we can use this testcase (from bug 467514).
I added this filter |https://www.google.$popup and clicked on "Click here". The popup/new window was closed as expected (old behaviour).
did you try
?