Opened on 09/19/2016 at 12:47:47 PM
Closed on 10/06/2016 at 01:03:13 PM
Last modified on 10/20/2016 at 01:50:01 PM
#4445 closed defect (fixed)
ABP icon disappears after updating to 2.7.3.4201
| Reported by: | arthur | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Nightly 51.0a1 (20160918030408)
ABP 2.7.3.4201
Windows 10 Pro
How to reproduce
- Install/Update to the latest dev build
Observed behaviour
The ABP icon disappears from the navigation bar.
Expected behaviour
The icon should stay.
Notes
- The drop down icon is still clickable
- Also reproducible with Firefox 48.0.2
Background
In #4409 we set a fixed width and height for the toolbar icon. Turned out, on Windows this toolbar icon has paddings in order to accommodate the dropdown arrow - the resulting content size gets too small because of that. Applying box-sizing: content-box to the element doesn't show any effect, probably because of XUL specifics.
Attachments (1)
Change History (7)
comment:1 Changed on 09/19/2016 at 09:19:10 PM by mapx
- Cc mapx added
comment:2 Changed on 09/20/2016 at 04:40:34 PM by mapx
comment:3 Changed on 09/23/2016 at 11:31:03 PM by fanboy
Maybe related too https://hg.adblockplus.org/adblockplus/rev/8df828ef2894 ?
And yes I'm seeing it too.
Changed on 10/01/2016 at 06:17:32 AM by blackcap95
Portion of Firefrox 50.0b3 window in Linux Mint 18 showing the effect of the missing ABP icon
comment:4 Changed on 10/06/2016 at 01:03:13 PM by trev
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Firefox-next
- Priority changed from Unknown to P1
- Ready set
- Resolution set to fixed
- Status changed from new to closed
I rolled back the change in question with https://hg.adblockplus.org/adblockplus/rev/14e4e1982152 - it seems that the fix only works on OS X and breaks things on Windows. Currently I don't see any approach that would work with both, the platform-specific Firefox themes are too different.
comment:5 Changed on 10/07/2016 at 03:56:03 AM by blackcap95
Verified fixed in Firefox 50.0b4 on Linux Mint 18 MATE.
comment:6 Changed on 10/20/2016 at 01:50:01 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed/rolled back.
ABP 2.7.3.4214-beta
Firefox 45 / 48 / Ubuntu 14.04 (High DPI)
Firefox 38 / 46 / 49 / Windows 7
Firefox Nightly 52.0a1 (2016-10-20) / OS X 10.12
icon disappeared in firefox 49.0 too