Opened on 09/29/2016 at 11:52:22 PM

Closed on 10/14/2016 at 07:34:10 PM

Last modified on 10/19/2016 at 07:32:04 AM

#4485 closed change (fixed)

Clear cache directory

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.4
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By: #4463
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29355392/

Description (last modified by diegocarloslima)

Background

Currently, our app doesn't delete any temporary filter file and the cache size grows indefinitely.

What to change

Clear old filter files as soon as one new filter file is generated.

Hints for Testers

Activate Adblock Plus for Samsung Browser in Samsung Internet

New files are created when some of the filter state (activated/deactivated) changes in ABP app

To see how much of storage is consumed by our app, go to device Settings -> Application Manager -> Adblock Plus for Samsung Browser -> Storage

Check wether the Cache storage stays stable (below 50MB) on every new file creation

Attachments (0)

Change History (6)

comment:1 Changed on 09/30/2016 at 02:52:46 AM by diegocarloslima

  • Blocked By 4463 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/13/2016 at 03:58:29 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.4

comment:3 Changed on 10/14/2016 at 07:22:35 PM by abpbot

A commit referencing this issue has landed:
​Issue 4485 - Clear cache directory

comment:4 Changed on 10/14/2016 at 07:34:10 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 10/17/2016 at 01:15:44 PM by diegocarloslima

  • Description modified (diff)

comment:6 Changed on 10/19/2016 at 07:32:04 AM by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • Adding all available lists and disabling them never bought the cache higher than 7.40MB's. Upon removing the lists, the cache reduced correctly (down to 2.40MB's) on each selection and de-selection.

ABB for Android 1.0.4
Android 5.0.2
Android 6.0.1
Galaxy S7
Note 3

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.