Opened on 10/10/2016 at 03:02:23 PM

Closed on 01/11/2017 at 05:19:32 PM

Last modified on 05/10/2017 at 07:43:36 AM

#4513 closed change (fixed)

Update app theme

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29356468/

Description

Background

Since our min SDK version is 21 (Lollipop), we should use Material Theming instead of Holo to provide a better user experience.

What to change

Update theme from Holo to Material

Attachments (2)

holo.png​ (214.2 KB) - added by diegocarloslima on 05/09/2017 at 01:43:46 PM.
material.png​ (146.1 KB) - added by diegocarloslima on 05/09/2017 at 01:43:59 PM.

Download all attachments as: .zip

Change History (10)

comment:1 Changed on 10/10/2016 at 07:02:08 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/11/2016 at 08:51:04 PM by diegocarloslima

  • Ready set

comment:3 Changed on 01/04/2017 at 05:30:49 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:4 Changed on 01/11/2017 at 05:19:10 PM by abpbot

A commit referencing this issue has landed:
​Issue 4513 - Update app theme

comment:5 Changed on 01/11/2017 at 05:19:32 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 05/02/2017 at 09:20:41 AM by scheer

@deigocarloslima - is there any way for me to see the difference here, as in, what is the intended look now?

Changed on 05/09/2017 at 01:43:46 PM by diegocarloslima

Changed on 05/09/2017 at 01:43:59 PM by diegocarloslima

comment:7 Changed on 05/09/2017 at 01:45:15 PM by diegocarloslima

@scheer, I've added two screenshots that illustrates the look and feel in the Holo theme and in the Material theme

comment:8 Changed on 05/10/2017 at 07:43:36 AM by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The Material app theme is used correctly across devices.

adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0

adblockplussbrowser-release-signed-1
Galaxy S4
Android 5.0.1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.