Opened on 10/11/2016 at 06:44:16 AM
Closed on 11/10/2017 at 11:15:18 AM
#4515 closed change (rejected)
Count hits for CSS property filters when an element is hidden, not when a matching CSS rule is found
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
With #3969 we now count hits for CSS property filters. However, a hit is counted when a filter matches a CSS rule in the document, regardless of whether this CSS rule actually affects any elements.
What to change
Rather than using display: none in order to hide elements, apply a binding via abp-elemhide: protocol to count hits whenever an element is hidden - as it is done with usual element hiding rules.
Attachments (0)
Change History (1)
comment:1 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.