Leaking and stacking dialogs in MainPreferences

[diegocarloslima]

Background

The dialogs created in MainPreferences aren't dismissed when the app goes to background and new ones are created every time the app goes to foreground. This may result in many instances of a dialog being showed and also a WindowLeaked error if the app is killed like the following:

10-11 17:46:24.555 24749-24749/org.adblockplus.adblockplussbrowser E/WindowManager: android.view.WindowLeaked: Activity org.adblockplus.sbrowser.contentblocker.MainPreferences has leaked window com.android.internal.policy.PhoneWindow$DecorView{a4f959a V.E...... R....... 0,0-1026,830} that was originally added here
    at android.view.ViewRootImpl.<init>(ViewRootImpl.java:368)
    at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:299)
    at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:85)
    at android.app.Dialog.show(Dialog.java:319)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkSetupStatus(MainPreferences.java:187)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkAAStatusAndProceed(MainPreferences.java:162)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkForCompatibleSBrowserAndProceed(MainPreferences.java:132)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.onEngineCreated(MainPreferences.java:201)
    at org.adblockplus.sbrowser.contentblocker.engine.EngineService$CreationNotifier$1.run(EngineService.java:152)
    at android.os.Handler.handleCallback(Handler.java:739)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:148)
    at android.app.ActivityThread.main(ActivityThread.java:5417)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

What to change

Make sure that when app goes to background, the current active dialog is dismissed and recreated when the app goes back to foreground.

[abpbot]

A commit referencing this issue has landed:
​Issue 4522 - Leaking and stacking dialogs in MainPreferences

[scheer]

• When the app goes to background, the current active dialog is dismissed and recreated when the app goes back to foreground and does not display the following error message:

24749-24749/org.adblockplus.adblockplussbrowser E/WindowManager: android.view.WindowLeaked: Activity org.adblockplus.sbrowser.contentblocker.MainPreferences has leaked window com.android.internal.policy.PhoneWindow$DecorView{a4f959a V.E...... R....... 0,0-1026,830} that was originally added here
    at android.view.ViewRootImpl.<init>(ViewRootImpl.java:368)
    at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:299)
    at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:85)
    at android.app.Dialog.show(Dialog.java:319)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkSetupStatus(MainPreferences.java:187)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkAAStatusAndProceed(MainPreferences.java:162)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.checkForCompatibleSBrowserAndProceed(MainPreferences.java:132)
    at org.adblockplus.sbrowser.contentblocker.MainPreferences.onEngineCreated(MainPreferences.java:201)
    at org.adblockplus.sbrowser.contentblocker.engine.EngineService$CreationNotifier$1.run(EngineService.java:152)
    at android.os.Handler.handleCallback(Handler.java:739)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:148)
    at android.app.ActivityThread.main(ActivityThread.java:5417)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0