Opened on 10/17/2016 at 08:09:52 AM
Closed on 10/17/2016 at 02:25:34 PM
Last modified on 10/25/2016 at 11:27:48 AM
#4533 closed defect (fixed)
Element Hiding Helper button is gone from Inspector toolbar
| Reported by: | magicp | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.3.10 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | trev, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Platform: Windows, Linux and Mac OS X
Firefox: 52.0a1 Nightly
Adblock Plus 2.7.3
Element Hiding Helper 1.3.9
STR:
- Start latest Nightly with Adblock Plus and Element Hiding Helper
- Open DevTools > Inspector
- Check the Element Hiding Helper button in Inspector toolbar
Actual result
Element Hiding Helper button is gone from Inspector toolbar
Expected result
The Element Hiding Helper button will be displayed in Inspector toolbar
Background
Developer tools switched from XUL to HTML. We are creating our button with the default namespace however which is no longer XUL now.
Attachments (1)
Change History (10)
Changed on 10/17/2016 at 08:13:55 AM by magicp
comment:1 Changed on 10/17/2016 at 08:37:42 AM by mapx
- Cc trev mapx added
comment:2 Changed on 10/17/2016 at 08:38:15 AM by mapx
comment:3 Changed on 10/17/2016 at 08:43:29 AM by trev
No, this isn't fixed in the development builds - I can reproduce this, seems to be a recent regression.
comment:4 Changed on 10/17/2016 at 08:52:28 AM by trev
The button is there, right next to the "plus" icon. However, it has no image because our styles don't apply for some reason. Also, clicking it doesn't seem to do anything.
comment:5 Changed on 10/17/2016 at 08:59:15 AM by trev
- Component changed from Unknown to Extensions-for-Adblock-Plus
- Description modified (diff)
- Owner set to trev
- Priority changed from Unknown to P1
- Ready set
comment:6 Changed on 10/17/2016 at 09:00:47 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 10/17/2016 at 02:23:44 PM by abpbot
A commit referencing this issue has landed:
Issue 4533 - Don't rely on the default namespace to be XUL for DevTools
comment:8 Changed on 10/17/2016 at 02:25:34 PM by trev
- Milestone set to Element-Hiding-Helper-1.3.10
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 10/25/2016 at 11:27:48 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed in Nightly. Still working in previous versions.
Firefox 38 / 48 / Nightly 52.0a1 (2016-10-23)
Firefox 45 / Ubuntu 14.04
Could you try the last dev build ?
https://addons.mozilla.org/downloads/latest-beta/adblock-plus/adblockplus-devbuild.xpi