Opened on 10/17/2016 at 03:45:04 PM

Closed on 10/31/2016 at 02:09:00 PM

#4544 closed change (fixed)

Consider platformHTMLBindings.xml when detecting available keyboard shortcuts

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361133/

Description

Background

keySelector.js currently looks for <xul:key> elements in the browser window when determining which shortcuts are already taken. This check misses Accel-Shift-V key however ("paste as plain text").

What to change

Take <xbl:handler> elements from chrome://global/content/platformHTMLBindings.xml into consideration as well, this is where Accel-Shift-V key is defined.

Attachments (0)

Change History (5)

comment:1 Changed on 10/17/2016 at 03:45:21 PM by trev

  • Summary changed from Consider platformHTMLBindings.xml when detecting available keyboard shortcust to Consider platformHTMLBindings.xml when detecting available keyboard shortcuts

comment:2 Changed on 10/31/2016 at 10:03:04 AM by trev

  • Owner set to trev

comment:3 Changed on 10/31/2016 at 10:08:54 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/31/2016 at 02:08:23 PM by abpbot

comment:5 Changed on 10/31/2016 at 02:09:00 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.