Opened on 10/20/2016 at 11:26:16 AM
Closed on 10/24/2016 at 03:07:06 PM
Last modified on 10/24/2016 at 03:07:40 PM
#4555 closed change (rejected)
Use imports instead of fully qualified name in BrowserApp
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P5 | Milestone: | |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In order to provide better code readability, change fully qualified name usage to simple name + imports in BrowserApp.java
What to change
Replace instances that contains fully qualified name by its simple name and add an import statement
Attachments (0)
Change History (5)
comment:1 Changed on 10/20/2016 at 11:29:15 AM by diegocarloslima
- Blocking 3135 added
comment:2 Changed on 10/20/2016 at 12:06:32 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/20/2016 at 01:23:07 PM by fhd
- Ready unset
comment:4 Changed on 10/24/2016 at 03:07:06 PM by diegocarloslima
- Resolution set to rejected
- Status changed from reviewing to closed
As we discussed on IRC, we'll keep the changes on upstream code minimal, meaning that we keep fully qualified names
comment:5 Changed on 10/24/2016 at 03:07:40 PM by diegocarloslima
- Blocking 3135 removed
Note: See
TracTickets for help on using
tickets.
Please note that we avoided the imports deliberately to avoid conflicts with upstream merges - BrowserApp.java gets changed a lot by Mozilla. In general we're trying to modify as few lines as possible when we touch upstream code.
If you still think it'd be better to use imports, let's get a third opinion.