Opened on 10/27/2016 at 10:20:16 AM
Closed on 01/10/2017 at 01:51:56 PM
#4578 closed change (fixed)
Make uap3:AppExtension.Id configurable for Microsoft Edge builds
| Reported by: | sebastian | Assignee: | wspee |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | kvas, oleksandr | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by wspee)
Background
During the review of the packager (#4028), I claimed that the Id attribute of the uap3:AppExtension node in AppxManifest.xml always needs to be set to EdgeExtension. Hence it got hard-coded, but apparently this was a misconception.
Initially, that value could be set to any floating point number. However, changing this field caused Microsoft Edge to recognize the extension as a completely different extension. So they changed the validation in the Windows Store to force this field to be set to EdgeExtension (string) for all new extensions (like our development build), while forcing the value not to change for existing extensions (like our release version).
So now we are in a situation where the Adblock Plus development builds must use the value EdgeExtension, while the release builds need to keep the value 1.0.
What to change
Add a metadata option to make the Id attribute of the uap3:AppExtension node in AppxManifest.xml configure. Fall back to EdgeExtension if the option is missing.
Attachments (0)
Change History (5)
comment:1 Changed on 11/25/2016 at 03:55:53 PM by sebastian
- Keywords goodfirstbug added
comment:2 Changed on 12/13/2016 at 11:14:58 AM by wspee
- Owner set to wspee
comment:3 Changed on 12/16/2016 at 10:28:10 AM by wspee
- Review URL(s) modified (diff)
- Status changed from new to reviewing
A commit referencing this issue has landed:
Issue 4578 - Make uap3:AppExtension.Id configurable for Microsoft Edge builds