Opened on 11/08/2016 at 10:12:57 AM
Closed on 12/02/2016 at 05:54:19 AM
#4619 closed defect (fixed)
Acceptable Ads are not displayed at the end of the search results on Kayak.com in AdblockWebView
| Reported by: | scheer | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Anton, sergz | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
With AA enabled, related ads should be shown at the bottom of search results on http://www.kayak.com, but currently, no ads are shown at all. The Chrome screenshot depicts how ads should appear on the mobile site.
Environment
AdblockWebView (95) Lightning Browser
Galaxy S7
Android 6.0.1
Easylist
AA Enabled
How to reproduce
- Enable Acceptable Ads
- Navigate to http://www.kayak.com
- Enter search criteria and search
Observed behaviour
No related acceptable ads are shown at the bottom of the search results.
Expected behaviour
Acceptable ads should be shown at the bottom of the search criteria.
Attachments (4)
Change History (13)
Changed on 11/08/2016 at 10:13:18 AM by scheer
Changed on 11/08/2016 at 10:13:28 AM by scheer
Changed on 11/08/2016 at 10:13:38 AM by scheer
comment:1 Changed on 11/08/2016 at 10:22:19 AM by asmirnov
comment:2 Changed on 11/08/2016 at 11:25:42 AM by asmirnov
i've temporarily removed "kayak.ru/mobileads" from blocking and i've found AA is shown now.
changed source code (AdblockWebView):
if (adblockEngine.matches(url, contentType, referrerChainArray))
{
if (url.startsWith("https://www.kayak.ru/s/mobileads/"))
{
w("Temporarily (hardcoded) exclude this URL (" + url + ") from blocking");
}
else
{
w("Blocked loading " + url);
// if we should block, return empty response which results in 'errorLoading' callback
return new WebResourceResponse("text/plain", "UTF-8", null);
}
}
d("Allowed loading " + url);
// continue by returning null
return null;
log:
11-08 16:19:27.054 24070-24197 D/AdblockWebView: Header referrer for https://www.kayak.ru/s/mobileads/hotel?_pt_=1&checkin_date=08.11.2016&checkout_date=11.11.2016&citycode=14713&gdadPage=mwebresults&gdads=1>adPage=1>ads=4&guests=2&initialRequest=true&inlines=1&output=json&rooms=1&searchid=uMEEA3ooco&version=1 is https://www.kayak.ru/hotels/%D0%9C%D0%BE%D1%81%D0%BA%D0%B2%D0%B0,%D0%A0%D0%BE%D1%81%D1%81%D0%B8%D1%8F-c14713/2016-11-08/2016-11-11/2guests?ispredir=true
11-08 16:19:27.054 24070-24197 D/AdblockWebView: Checking .matches() https://www.kayak.ru/s/mobileads/hotel?_pt_=1&checkin_date=08.11.2016&checkout_date=11.11.2016&citycode=14713&gdadPage=mwebresults&gdads=1>adPage=1>ads=4&guests=2&initialRequest=true&inlines=1&output=json&rooms=1&searchid=uMEEA3ooco&version=1 with type OTHER, referrers:
#0: https://www.kayak.ru/hotels/%D0%9C%D0%BE%D1%81%D0%BA%D0%B2%D0%B0,%D0%A0%D0%BE%D1%81%D1%81%D0%B8%D1%8F-c14713/2016-11-08/2016-11-11/2guests?ispredir=true
11-08 16:19:27.064 24070-24197 W/AdblockWebView: Temporarily (hardcoded) exclude this URL (https://www.kayak.ru/s/mobileads/hotel?_pt_=1&checkin_date=08.11.2016&checkout_date=11.11.2016&citycode=14713&gdadPage=mwebresults&gdads=1>adPage=1>ads=4&guests=2&initialRequest=true&inlines=1&output=json&rooms=1&searchid=uMEEA3ooco&version=1) from blocking
11-08 16:19:27.064 24070-24197 D/AdblockWebView: Allowed loading https://www.kayak.ru/s/mobileads/hotel?_pt_=1&checkin_date=08.11.2016&checkout_date=11.11.2016&citycode=14713&gdadPage=mwebresults&gdads=1>adPage=1>ads=4&guests=2&initialRequest=true&inlines=1&output=json&rooms=1&searchid=uMEEA3ooco&version=1
so. it's blocked becuase filterEngine blocks it:
1) subscribed to AA
2) contenttype = OTHER (as it's not matched to known other regex patterns)
see attached ide screenshot
Changed on 11/08/2016 at 11:26:31 AM by asmirnov
AA is blocked by filter engine (IDE)
comment:3 Changed on 11/08/2016 at 11:31:44 AM by asmirnov
- Cc sergz added
comment:4 Changed on 11/08/2016 at 12:29:02 PM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 11/08/2016 at 12:42:45 PM by asmirnov
please confirm it's fixed in Lightning+ABP 96
comment:6 Changed on 11/08/2016 at 12:49:26 PM by asmirnov
Exception is for XmlHttpRequest
@@/s/mobileads/*$xmlhttprequest,domain=kayak.com.au|kayak.com.br|checkfelix.com|kayak.dk|kayak.fr|kayak.com.hk|kayak.it|kayak.com.mx|kayak.nl|kayak.no|kayak.pl|kayak.ru|kayak.sg|kayak.es|kayak.se|kayak.ch|swoodoo.com|kayak.co.uk|kayak.com|kayak.de|kayak.co.in|kayak.ie|kayak.pt|kayak.se|kayak.com.tr
and contentType was OTHER. Now we detect if it's XmlHttpRequest using header.
Unfortunately it will not work before android-21 (5.0) as request headers are not available.
comment:7 Changed on 11/10/2016 at 08:42:28 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- Acceptable Ads are now correctly shown at the end of the search results.
AdblockWebView (97) Lightning Browser
Galaxy S7
Android 6.0.1
comment:8 Changed on 12/02/2016 at 05:54:10 AM by asmirnov
The source code changes will be included in issue 4399 files
comment:9 Changed on 12/02/2016 at 05:54:19 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
i can see no AA elem hide selectors and some ad requests are rejected: