Opened on 11/14/2016 at 07:52:12 PM
Closed on 01/16/2017 at 07:20:45 AM
#4644 closed change (fixed)
Implement request filtering for Adblock Plus devtools panel
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | greiner, sebastian, mapx | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29362522/ |
||
Description
Background
With issue #154 we added a Adblock Plus developer tools panel which shows the requests for a page, if they have been blocked / whitelisted and if so which filter did that. Chrome developer tools panels have a standard search interface but so far we don't use it.
It would be really useful to be able to filter the requests using the standard search interface. (I needed it for issue #4598.)
What to change
- Add a onSearch listener and pass the performSearch and cancelSearch details through to the devtools content script using postMessage.
- Add a message listener to the content script and hide / show requests accordingly.
Attachments (0)
Change History (7)
comment:1 Changed on 11/14/2016 at 07:58:30 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/14/2016 at 08:00:58 PM by mapx
while on it (dev ABP panel) could you see also: https://issues.adblockplus.org/ticket/4226
?
comment:3 Changed on 11/14/2016 at 08:08:22 PM by kzar
Well it's on the list but I don't have time to look into that one right now, sorry. :(
comment:4 Changed on 11/30/2016 at 03:48:46 PM by abpbot
A commit referencing this issue has landed:
Issue 4644 - Filter requests in devtools panel by search string
comment:5 Changed on 01/07/2017 at 10:35:27 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:6 Changed on 01/16/2017 at 07:20:07 AM by abpbot
A commit referencing this issue has landed:
Issue 4644 - Pass search messages to our devtools panel
comment:7 Changed on 01/16/2017 at 07:20:45 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
(I hope you'll forgive that I didn't create a separate adblockplusui issue for this.)