Opened on 11/18/2016 at 01:24:12 PM

Closed on 08/15/2017 at 09:38:59 AM

Last modified on 08/15/2017 at 09:58:56 AM

#4651 closed defect (fixed)

Remove click-event from version string

Reported by: mario Assignee: ashephard
Priority: P3 Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: pavelz, dedecej Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29512610/

Description

Environment

ABP for iOS 1.1.0
Any iOS version

How to reproduce

  1. Open ABP for iOS
  2. Skip the onboarding-slides if they appear
  3. Tap "about"
  4. Tap the list element containing the version string

Observed behaviour

The version string list element gains focus and changes its color to grey without any action happening.

Expected behaviour

The version string list item doesn't gain focus and doesn't change color.

Attachments (0)

Change History (5)

comment:1 Changed on 08/07/2017 at 01:48:57 PM by ashephard

  • Owner set to ashephard

comment:2 Changed on 08/14/2017 at 01:28:31 PM by ashephard

  • Status changed from new to reviewing

comment:3 Changed on 08/14/2017 at 02:24:47 PM by abpbot

A commit referencing this issue has landed:
​Issue 4651 - Disabled table view selection for cells

comment:4 Changed on 08/15/2017 at 09:38:59 AM by ashephard

  • Milestone set to Adblock-Plus-for-iOS-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/15/2017 at 09:58:56 AM by ashephard

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.