Opened on 11/21/2016 at 09:42:21 AM
Closed on 09/13/2017 at 06:27:19 PM
Last modified on 10/11/2017 at 08:08:44 PM
#4655 closed defect (fixed)
Removing an installed search engine replaces it with a new search option
| Reported by: | passbrains | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Due to a change introduced in #3128 , the Search preference only shows up to 5 Installed search engines, even if more than that are installed.
Given that, removing a search engine, going back to the Settings and then back into the Search pane shows new search engines previously not shown.
This appears quite odd to me, as in one of the cases Twitter was shown as a possible search engine option when re-entering the Search section.
Environment
Asus + Nexus 7 + Android 5.1
Galaxy S5 + Android 5.0.1
How to reproduce
- Load ABB Android and tap the Menu button
- Tap Settings
- Tap Search
- Select the Google search option (or any other search engine)
- Tap Remove
- See Google is removed from the list
- Tap Back button
- Tap Search option again
- Observe Search engines list
Observed behaviour
Removing a search engine, then navigating back and then back into the Search pane, a new Search Engine is shown, that was not previously available.
Expected behaviour
All search engine options should be visible when in the Search options Pane.
Attachments (4)
Change History (14)
Changed on 11/21/2016 at 09:42:23 AM by passbrains
Changed on 11/21/2016 at 09:42:23 AM by passbrains
Changed on 11/21/2016 at 09:42:24 AM by passbrains
Changed on 11/21/2016 at 09:42:25 AM by passbrains
comment:1 Changed on 11/21/2016 at 09:42:27 AM by passbrains
comment:2 Changed on 11/21/2016 at 09:53:05 AM by scheer
- Component changed from Unknown to Adblock-Browser-for-Android
- Description modified (diff)
- Summary changed from When remove one of the Search engines, it automatically installs new one to Removing an installed search engine replaces it with a new search option
comment:3 Changed on 08/18/2017 at 01:05:03 PM by diegocarloslima
- Priority changed from Unknown to P3
comment:4 Changed on 08/28/2017 at 08:02:07 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Owner set to diegocarloslima
- Ready set
comment:5 Changed on 08/28/2017 at 08:02:19 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/13/2017 at 06:25:42 PM by abpbot
A commit referencing this issue has landed:
Issue 4655 - Removing an installed search engine replaces it with a new search option
comment:7 Changed on 09/13/2017 at 06:27:19 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 10/11/2017 at 08:08:44 PM by traynard
- Verified working set
1 - 21 Nov 2016 10:38:08 posted by Scott Cheer
Reproduced ABB Android 1.1.1 (Play Store)
Galaxy S5
Android 5.0.1