Opened on 05/12/2014 at 08:13:23 AM
Closed on 06/21/2014 at 02:59:54 PM
#466 closed change (fixed)
[ABP for IE] Replace "ChinaList" with "EasyList China"
| Reported by: | philll | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.2-for-Internet-Explorer |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | ie_devbuild_1.2 |
| Cc: | trev, oleksandr, smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
See #204. We fixed this for all current environments except Internet Explorer.
What to change
In the default filter lists offered in the options page dropdown of ABP for IE, change the list entry label "ChinaList" to "EasyList China"
Attachments (0)
Change History (12)
comment:1 Changed on 05/12/2014 at 09:29:03 AM by trev
- Cc trev oleksandr added
comment:2 Changed on 05/19/2014 at 07:00:46 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 05/19/2014 at 07:44:24 AM by mapx
the home page (in the review) is still wrong
it should be http://abpchina.org/forum/
and not http://chinalist.github.io/
comment:4 Changed on 05/19/2014 at 07:45:18 AM by mapx
- Cc smultron45@gmail.com added
comment:5 Changed on 05/19/2014 at 07:47:37 AM by oleksandr
Changed the homepage as well now
comment:6 Changed on 05/19/2014 at 07:53:23 AM by mapx
well, also the title and author...like here:
https://adblockplus.org/en/subscriptions/
EasyList China
supplement for EasyList by John, Li, Jiefei
Homepage, Changelog
Subscribe: EasyList China+EasyList, EasyList China
comment:7 Changed on 05/19/2014 at 08:06:13 AM by trev
Oleksandr, please don't change subscriptions.xml manually - that's an autogenerated file. That file has been updated in the adblockplus repository already, all you need to do is linking against the current state of libadblockplus.
comment:8 Changed on 06/02/2014 at 03:40:46 PM by oleksandr
- Owner set to oleksandr
comment:9 Changed on 06/05/2014 at 01:11:56 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-next
comment:10 Changed on 06/18/2014 at 06:30:26 PM by philll
- Keywords ie_devbuild_1.2 added
comment:11 Changed on 06/21/2014 at 02:59:36 PM by oleksandr
adblockplus in libadblockplus was updated in https://hg.adblockplus.org/libadblockplus/changeset/042e60eb83a8
comment:12 Changed on 06/21/2014 at 02:59:54 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
Oleksandr, could you look into this? You need to update the dependency on libadblockplus repository.