Opened on 11/30/2016 at 01:33:21 PM
Closed on 11/30/2016 at 01:53:59 PM
#4676 closed change (fixed)
Replace non-standard CSSStyleSheet.addRule() call by CSSStyleSheet.insertRule()
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
include.preload.js calls CSSStyleSheet.addRule() in order to add a style rule. This is a non-standard method introduced in Internet Explorer and apparently implemented in Chrome for compatibility reasons. Firefox doesn't support it.
What to change
Call the standard CSSStyleSheet.insertRule() method.
Attachments (0)
Change History (4)
comment:1 Changed on 11/30/2016 at 01:37:36 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/30/2016 at 01:46:28 PM by kzar
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 11/30/2016 at 01:52:48 PM by abpbot
comment:4 Changed on 11/30/2016 at 01:53:59 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4676 - Replace non-standard CSSStyleSheet.addRule() call by CSSStyleSheet.insertRule()