Opened on 12/02/2016 at 10:25:54 AM

Closed on 01/19/2017 at 01:58:06 PM

#4685 closed change (fixed)

Update images on eyeo.com

Reported by: saroyanm Assignee: erick
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: Marsha, jeen, christiane, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29369432/

Description (last modified by saroyanm)

Background

Currently images on eyeo.com are outdated.

What to change

Add/change on pages below:

Change favicon:

Attachments (18)

eyeo-home-1.jpg​ (445.6 KB) - added by saroyanm on 12/02/2016 at 10:27:04 AM.
Main image
hr-1.JPG​ (170.3 KB) - added by saroyanm on 12/02/2016 at 10:27:18 AM.
hr-2.jpg​ (532.9 KB) - added by saroyanm on 12/02/2016 at 10:27:24 AM.
hr-3.jpg​ (287.4 KB) - added by saroyanm on 12/02/2016 at 10:27:30 AM.
hr-4.jpg​ (215.0 KB) - added by saroyanm on 12/02/2016 at 10:27:37 AM.
hr-5.jpg​ (418.2 KB) - added by saroyanm on 12/02/2016 at 10:27:44 AM.
hr-6.JPG​ (507.7 KB) - added by saroyanm on 12/02/2016 at 10:27:49 AM.
hr-7.jpg​ (489.2 KB) - added by saroyanm on 12/02/2016 at 10:27:58 AM.
hr-8.jpg​ (417.2 KB) - added by saroyanm on 12/02/2016 at 10:28:06 AM.
eyeo_icon-01.png​ (8.3 KB) - added by saroyanm on 12/02/2016 at 10:34:35 AM.
pr1
eyeo_tillfaida.jpg​ (256.2 KB) - added by saroyanm on 12/02/2016 at 10:34:43 AM.
pr2
eyeo_logo-01.png​ (11.1 KB) - added by saroyanm on 12/02/2016 at 10:34:50 AM.
pr3
AdblockPlus_logo.png​ (61.5 KB) - added by saroyanm on 12/02/2016 at 10:34:58 AM.
opr
AdblockBrowser_logo.png​ (43.5 KB) - added by saroyanm on 12/02/2016 at 10:35:07 AM.
pr5
eyeo_favicon_32.png​ (440 bytes) - added by saroyanm on 12/02/2016 at 10:35:33 AM.
favicon 32px
eyeo_favicon_64.png​ (882 bytes) - added by saroyanm on 12/02/2016 at 10:35:43 AM.
favicon 64px
eyeo-home-1x.png​ (751.3 KB) - added by juliandoucette on 01/11/2017 at 05:53:56 PM.
New homepage banner 1x
eyeo-home-2x.png​ (2.9 MB) - added by juliandoucette on 01/11/2017 at 05:55:02 PM.
New homepage bannner 2x

Download all attachments as: .zip

Change History (40)

Changed on 12/02/2016 at 10:27:04 AM by saroyanm

Main image

Changed on 12/02/2016 at 10:27:18 AM by saroyanm

Changed on 12/02/2016 at 10:27:24 AM by saroyanm

Changed on 12/02/2016 at 10:27:30 AM by saroyanm

Changed on 12/02/2016 at 10:27:37 AM by saroyanm

Changed on 12/02/2016 at 10:27:44 AM by saroyanm

Changed on 12/02/2016 at 10:27:49 AM by saroyanm

Changed on 12/02/2016 at 10:27:58 AM by saroyanm

Changed on 12/02/2016 at 10:28:06 AM by saroyanm

Changed on 12/02/2016 at 10:34:35 AM by saroyanm

pr1

Changed on 12/02/2016 at 10:34:43 AM by saroyanm

pr2

Changed on 12/02/2016 at 10:34:50 AM by saroyanm

pr3

Changed on 12/02/2016 at 10:34:58 AM by saroyanm

opr

Changed on 12/02/2016 at 10:35:07 AM by saroyanm

pr5

Changed on 12/02/2016 at 10:35:33 AM by saroyanm

favicon 32px

Changed on 12/02/2016 at 10:35:43 AM by saroyanm

favicon 64px

comment:1 Changed on 12/02/2016 at 10:54:59 AM by saroyanm

  • Component changed from Unknown to Websites
  • Description modified (diff)

comment:2 Changed on 12/02/2016 at 11:07:52 AM by saroyanm

  • Cc Marsha added

@Marsha, can you please confirm that the PR section looks Okey ?

comment:3 Changed on 12/02/2016 at 11:08:12 AM by saroyanm

  • Description modified (diff)

comment:4 Changed on 12/02/2016 at 11:10:30 AM by saroyanm

  • Description modified (diff)

comment:5 follow-up: Changed on 12/02/2016 at 07:08:22 PM by juliandoucette

  • Cc jeen christiane added

Are these approved by @jeen && @christiane?

comment:6 in reply to: ↑ 5 Changed on 12/05/2016 at 07:49:06 PM by saroyanm

Replying to juliandoucette:

Are these approved by @jeen && @christiane?

They was provided by Christiane, so I assume - yes.

HR related section approved by @Maren, PR related waiting for the response from @Marsha, in addition @jeen if you have concerns regarding the images please let me know, I'm waiting for PR feedback to mark this as ready.

comment:7 Changed on 12/07/2016 at 04:13:22 PM by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

Just aligned with @Marsha and PR section as described in the ticket is fine.

comment:8 Changed on 12/07/2016 at 04:20:16 PM by jeen

I'm fine with the images.

comment:9 Changed on 12/12/2016 at 03:23:18 PM by juliandoucette

  • Owner set to juliandoucette
  • Priority changed from P3 to P2

Bumping this to P2 after aligning with Till.

I'll get something into review today.

comment:10 Changed on 12/13/2016 at 05:19:16 PM by juliandoucette

  • Owner juliandoucette deleted

comment:11 Changed on 12/16/2016 at 11:41:33 AM by erick

  • Owner set to erick

comment:12 Changed on 12/20/2016 at 05:48:06 PM by erick

  • Status changed from new to reviewing

comment:13 Changed on 12/20/2016 at 05:48:52 PM by erick

  • Review URL(s) modified (diff)

comment:14 Changed on 01/11/2017 at 01:29:47 PM by juliandoucette

  • Ready unset

@jeen, @christiane

These images were not sized & optimized properly. I'm on it.

EDIT: It doesn't make sense to combine the images on ​https://eyeo.com/en/jobs/#why actually (it's not accessible).

Last edited on 01/11/2017 at 01:37:23 PM by juliandoucette

comment:15 Changed on 01/11/2017 at 01:33:52 PM by juliandoucette

@jeen, @christiane

The text in the home page image is blurry.

I don't have the source file. Can you please create a 1x & 2x version with crisp text?

Last edited on 01/11/2017 at 01:35:39 PM by juliandoucette

Changed on 01/11/2017 at 05:53:56 PM by juliandoucette

New homepage banner 1x

Changed on 01/11/2017 at 05:55:02 PM by juliandoucette

New homepage bannner 2x

comment:16 Changed on 01/11/2017 at 05:57:38 PM by juliandoucette

I've attached the home page images received.

The optimized images can be found in the description of the review.

comment:17 Changed on 01/11/2017 at 05:58:23 PM by juliandoucette

  • Ready set

comment:18 Changed on 01/11/2017 at 06:10:12 PM by greiner

  • Cc greiner added

Merged #4585 and #4660 into this ticket.

comment:19 Changed on 01/13/2017 at 01:42:47 PM by abpbot

A commit referencing this issue has landed:
​Issue 4685 - Updated images to match new brand

comment:20 Changed on 01/18/2017 at 12:53:23 PM by Marsha

Last edited on 01/18/2017 at 03:46:39 PM by Marsha

comment:21 Changed on 01/18/2017 at 12:53:54 PM by Marsha

Last edited on 01/18/2017 at 12:54:35 PM by Marsha

comment:22 Changed on 01/19/2017 at 01:58:06 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from erick.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.