Opened on 12/02/2016 at 06:22:28 PM
Closed on 02/21/2018 at 05:06:58 PM
#4690 closed change (rejected)
Localize action attribute in adblockplus/cms
Reported by: | juliandoucette | Assignee: | jsonesen |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas, jsonesen, philll, saroyanm | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
- Anchor href is automatically localized if it's value is relative in adblockplus/cms
- Form action should function the same way
What to change
- Localize form action attribute automatically if it's value is relative in Markdown and HTML templates in adblockplus/cms
Attachments (0)
Change History (4)
comment:1 Changed on 01/09/2017 at 09:02:12 AM by jsonesen
- Owner set to jsonesen
comment:2 Changed on 01/09/2017 at 10:04:03 AM by jsonesen
comment:3 Changed on 07/10/2017 at 02:17:28 PM by juliandoucette
I don't know what you mean or how that is relevant.
I'm talking about the action attribute of the form element.
e.g.
<a href="page_name"> becomes <a href="/en/page_name">
but
<form action="page_name"> remains <form action="page_name">
comment:4 Changed on 02/21/2018 at 05:06:58 PM by juliandoucette
- Resolution set to rejected
- Status changed from new to closed
On second thought, I think that this is a bad idea because we should not assume that form actions are localized by directory.
Note: See
TracTickets for help on using
tickets.
Actually after testing this it appears that the link is actually dynamically localized once the action link is resolved.