Opened on 12/11/2016 at 11:41:40 AM

Closed on 01/19/2017 at 02:14:37 PM

#4726 closed change (fixed)

Add tests for the element hiding emulation content script

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: #3143 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29367181/

Description

Background

We currently don't have automated tests for the element hiding emulation content script (chrome/content/elemHideEmulation.js), that makes it difficult to change.

What to change

  1. Add a new class of tests that run in a browser environment. It should be possible to invoke them separately from the existing nodeunit tests.
  2. Add tests for the element hiding emulation content script.

Attachments (0)

Change History (2)

comment:1 Changed on 12/11/2016 at 12:14:51 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/19/2017 at 02:14:37 PM by fhd

  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

Landed: ​https://hg.adblockplus.org/adblockpluscore/rev/d575f050617e

The commit unfortunately references the wrong issue, #4276.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.