Opened on 12/12/2016 at 02:08:50 PM
Closed on 12/14/2016 at 12:17:05 AM
#4728 closed change (fixed)
Remove hard-coded references from statsmaster sitescripts.ini template
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | ferris, paco | Blocked By: | |
| Blocking: | #3576 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
In #3638 and #3639 we refactored our code-base to use a central mechanism for applying resources specific to other hosts within the current environment. This included updating the modules/statsmaster/templates/sitescripts.ini.erb template so filter-servers are not hard-coded any more for subscription and notification analysis (see https://hg.adblockplus.org/infrastructure/rev/818dc7bb93ac for more information). That template contains some other hard-coded host references though, which should get refactored in the same fashion.
What To Do =
Replace mirror_download$i=download ... and mirror_update$i=update ... lines in modules/statsmaster/templates/sitescripts.ini.erb with sitescripts::configfragment resources in modules/adblockplus/manifests/hosts/statsmaster.pp, analogous to the patch-set linked above.
Attachments (0)
Change History (4)
comment:1 Changed on 12/12/2016 at 02:09:21 PM by matze
- Owner set to matze
comment:2 Changed on 12/12/2016 at 02:20:09 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/14/2016 at 12:15:18 AM by abpbot
comment:4 Changed on 12/14/2016 at 12:17:05 AM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 4728 - Remove hard-coded references from statsmaster sitescripts.ini template