Opened on 12/16/2016 at 10:03:45 AM
Closed on 09/13/2017 at 04:22:23 PM
Last modified on 09/15/2017 at 12:18:26 AM
#4742 closed change (fixed)
[UI] Redesign history screen
Reported by: | mario | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-2.0.0 |
Module: | Adblock-Browser-for-iOS | Keywords: | blocked |
Cc: | Blocked By: | ||
Blocking: | #4706 | Platform: | Adblock Browser for iOS |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | yes |
Review URL(s): |
Description (last modified by mario)
Background
This issue is part of ABB's redesign as described under #4706.
Logic/UI which is not covered within this issue stays in place as it is.
What to change
Apply the new design to ABB's history as shown in this mockup and this guide
Transitions
- When the history screen is opened, slide it in from the right using iOS' default transition.
Logic
- If the history screen is shown as shown in this mockup:
- Mark the back icon in the bottom bar inactive
- Mark the forward icon in the bottom bar inactive
- Mark the tabs icon in the bottom bar inactive
- Mark the ghost mode icon in the bottom bar inactive
- Mark the bookmark icon in the bottom bar inactive
Copy
- Headline: Recent History
Attachments
Style Guides
Assets
Mockups (as shown in description)
Attachments (2)
Change History (20)
Changed on 12/16/2016 at 10:03:59 AM by mario
Changed on 12/16/2016 at 11:37:31 AM by mario
comment:3 Changed on 12/16/2016 at 02:30:13 PM by lisabielik
comment:4 Changed on 01/18/2017 at 01:07:14 PM by mario
- Ready set
comment:5 Changed on 01/18/2017 at 01:11:34 PM by mario
- Priority changed from Unknown to P2
comment:6 Changed on 05/24/2017 at 09:42:14 AM by jand
During the implementation I encounter those problematic points:
- Back button: There is a back button in history view which is named Recent History. That design is inconsistent with iOS guidelines and the rest of the application, since usually title of the back button refers to title of the previous screen. I am suggesting to set the screen title to Recent History and leave title of the back button as it is (Back).
- No History Available text: There is a label, which is displayed, when there are no items in history list. This issue does not mention that label. Should I preserve that label or should I remove it?
comment:7 Changed on 06/06/2017 at 08:06:44 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed on 07/10/2017 at 07:52:04 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:9 Changed on 07/25/2017 at 08:14:41 PM by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
- When viewing the history window, if you attempt to open any page in the browser history, the history window closes and the user remains on the same page. Link from history does not open.
Steps to Reproduce:
-Click hamburger menu
-Click history
-Tap to open a past website
comment:10 Changed on 08/07/2017 at 02:54:44 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:11 Changed on 08/10/2017 at 05:43:44 PM by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
When clicking on a website in history, the page properly opens as expected. However, for a moment the colon (:), forward slash (/), hyphen (-), period (.) and .com buttons flash before the page is loaded.
Video Example (file too large to attach):
https://drive.google.com/a/adblockplus.org/file/d/0B7fTL_3kBY9LM0ZDZXdfckhyczQ/view?usp=sharing
comment:12 Changed on 08/18/2017 at 01:39:24 PM by jand
I was unable to reproduce this issue. Does it happen on the TestObjects? Which device? Which iOS version have you been using?
comment:13 Changed on 08/18/2017 at 01:39:58 PM by jand
- Keywords blocked added
comment:14 Changed on 08/21/2017 at 09:26:49 AM by mario
@jand, It not only happens on TestObject but on real devices as well. In my case, it's an iPhone 6, iOS 10.3.2.
As soon as you tap an entry in the history, there appears to be a glitch with the keyboard and the top row of the keyboard is visible for a second. In the video, it can be hard to catch. Look at the bottom third of the screen when a history item is tapped.
comment:15 Changed on 08/24/2017 at 01:02:13 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:16 Changed on 09/11/2017 at 05:57:38 PM by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
When attempting to delete the history, it does not clear until user backs out.
Steps to Replicate:
*Ensure a history exists in ABB. Navigate to a few sites if not*
- Click Hamburger Menu
- Tap "History"
- Tap "Delete"
- Tap "Clear" on confirmation popup
Current Results:
History remains visible to user. It looks like the history was not cleared
Expected Results:
History should clear immediately after action is completed.
Note: If you tap "Back" after deleting history and navigate back to the history, it will be cleared as expected. However, to users it will look like the history is never deleted.
comment:17 Changed on 09/13/2017 at 04:22:23 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:18 Changed on 09/15/2017 at 12:18:26 AM by traynard
- Verified working set
lgtm