Opened on 12/30/2016 at 09:25:37 AM
Closed on 01/20/2017 at 10:55:23 AM
Last modified on 02/21/2017 at 10:04:20 AM
#4762 closed change (fixed)
Add relentless notification type
| Reported by: | wspee | Assignee: | wspee |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | fhd, sebastian, philll, trev, greiner | Blocked By: | |
| Blocking: | #4764 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
For legal reasons we want to inform our users, on certain websites, that "false positives" (blocked content that is not an ad) can occur.
What to change
To allow that add a new notification type "relentless" that:
- Shows a desktop notification that contains only text (like a normal notification)
- Can be closed but not deactivated
- Shows up in regular intervals via an attribute named "interval" that defines the interval in milliseconds
Attachments (0)
Change History (12)
comment:1 Changed on 12/30/2016 at 09:54:39 AM by wspee
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/02/2017 at 09:24:45 AM by fhd
- Cc fhd added
- Priority changed from Unknown to P1
comment:3 Changed on 01/02/2017 at 11:15:52 AM by wspee
- Blocking 4764 added
comment:5 follow-up: ↓ 7 Changed on 01/05/2017 at 12:06:39 PM by sebastian
- Cc sebastian philll trev added
- Ready unset
The issue doesn't specify when such a notification should be shown, I suppose we would want to show that notification when the user visits one out of a list of specific websites/domains?
Is it already established anyway that we want to that? When we discussed that in one of our previous team meetings this feature seemed to be quite controversial. Personally, I'd also rather like to avoid this, but rather have a disclaimer on the first run page for example, if possible.
Also please don't mark issues as Ready yourself, this is up to the module owner. Wladimir is the module owner for Core.
comment:6 Changed on 01/05/2017 at 01:26:47 PM by fhd
Is it already established anyway that we want to that? When we discussed that in one of our previous team meetings this feature seemed to be quite controversial. Personally, I'd also rather like to avoid this, but rather have a disclaimer on the first run page for example, if possible.
Yes, we need this for legal reasons, and will not use it for anything else. Not going into more detail so we can keep the issue public.
comment:7 in reply to: ↑ 5 ; follow-up: ↓ 8 Changed on 01/05/2017 at 01:29:43 PM by wspee
Replying to sebastian:
The issue doesn't specify when such a notification should be shown, I suppose we would want to show that notification when the user visits one out of a list of specific websites/domains?
Yes, there will be a separate issue to add the required notifications as a server side notification but I haven't created it yet because I don't have the required texts.
Also please don't mark issues as Ready yourself, this is up to the module owner. Wladimir is the module owner for Core.
Ok sorry, I looked into the TracGuide because I wasn't sure who is supposed to set the Ready flag but this isn't specified so I set it myself.
comment:8 in reply to: ↑ 7 Changed on 01/05/2017 at 01:42:26 PM by sebastian
Replying to wspee:
Ok sorry, I looked into the TracGuide because I wasn't sure who is supposed to set the Ready flag but this isn't specified so I set it myself.
The responsibilities of module owners are documented here. But it makes sense to be more explicit in the TracGuide as well, I just updated it.
comment:9 Changed on 01/12/2017 at 12:01:37 PM by greiner
- Cc greiner added
comment:10 Changed on 01/20/2017 at 10:41:25 AM by abpbot
A commit referencing this issue has landed:
Issue 4762 - Added "relentless" notification that shows up in intervals
comment:11 Changed on 01/20/2017 at 10:55:23 AM by wspee
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 02/21/2017 at 10:04:20 AM by abpbot
A commit referencing this issue has landed:
Issue 4762 - Added "relentless" notification that shows up in intervals
See #4764