Opened on 01/04/2017 at 06:03:15 PM
Closed on 03/09/2017 at 09:33:33 PM
Last modified on 08/25/2017 at 01:20:35 PM
#4772 closed change (fixed)
Add temporary fix for removing unsupported filters
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.0 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
Currently, Samsung Internet might crash if it's provided with some filter rule it can't parse. For that, we need to add a temporary fix in order to remove these rules. The current known problematic rules are the ones that starts with |$, ||$, @@|$ and @@||$. Once Samsung Internet handles properly these edge cases, we can remove this temporary fix in a follow up issue.
What to change
Before providing Samsung Internet with the filter file, we should remove all rules that starts with |$, ||$, @@|$ and @@||$
Remark for testers
The filters in question are removed during runtime. No separate copy of EasyList is fetched.
The following filters were identified as the initial cause for the crashes:
- @@||$third-party,image,domain=spec-komp.com
- @@||$third-party,popup,domain=top-game.su
The latter is still present in EasyList Russia. Thus this change can be tested by initializing EasyList Russia with Samsung Internet 4.0 and 5.0.
Attachments (0)
Change History (7)
comment:1 Changed on 01/06/2017 at 05:29:39 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/09/2017 at 09:31:26 PM by abpbot
comment:3 Changed on 03/09/2017 at 09:33:33 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/10/2017 at 11:22:32 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- With the Russian filter list initialised, Samsung browser 4.0 and 5.0 worked correctly across websites (Russian and English).
adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0
Samsung Internet 5.0.30-40
adblockplussbrowser-release-signed-1
Galaxy S4
Android 5.0.1
Samsung Internet 4.0.10-53
comment:7 Changed on 08/25/2017 at 01:19:45 PM by jwangenheim
Sorry, commented in the wrong ticket.
A commit referencing this issue has landed:
Issue 4772 - Add temporary fix for removing unsupported filters