Opened on 01/05/2017 at 12:02:02 PM
Closed on 01/31/2017 at 08:11:15 PM
Last modified on 06/19/2017 at 12:36:42 PM
#4774 closed defect (fixed)
'Block ads on this page' does not remove whitelisting when re-selected
| Reported by: | scheer | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | diegocarloslima | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
When the user unchecks the 'Block ads on this site' to disable ABP, the box is not unchecked, but the page is reloaded and ads are shown. The one issue here is that the box is not unchecked, but in addition to this, if the user then selects the 'Block ads on this site' option again, the page still shows all ads.
Looking into the Settings > Ad blocking > More blocking options section, there seems to be a Whitelist created when they first select the 'Block ads on this site' that is never un-checked when re-selecting the option again thereafter.
Environment
ABB Android Test 1.1.1
Android 6.0.1
Galaxy S7
How to reproduce
- Visit http://www.msn.com
- Select the settings burger
- Select 'Block ads on this site'
- Select the settings burger
- Select 'Block ads on this site'
Observed behaviour
The first selection whitelists the site, but the second selection does not remove the whitelist and ads are still shown.
Expected behaviour
The second selection should re-enable ABP and remove the whitelist.
Attachments (0)
Change History (3)
comment:1 Changed on 01/31/2017 at 08:09:54 PM by abpbot
comment:2 Changed on 01/31/2017 at 08:11:15 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Priority changed from Unknown to P3
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 06/19/2017 at 12:36:42 PM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The re-selection of the option 'Block ads on this page' correctly reloads the page and removes the whitelist to block all ads again.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
A commit referencing this issue has landed:
Issue 4774 - 'Block ads on this page' does not remove whitelisting when re-selected