Opened on 01/10/2017 at 07:43:53 AM

Closed on 01/19/2017 at 04:05:01 AM

Last modified on 01/19/2017 at 04:16:23 AM

#4783 closed change (fixed)

Switch message_responder.js to use the messaging API

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: #4579, #4823 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29370996/
​https://codereview.adblockplus.org/29370999/
​https://codereview.adblockplus.org/29371585/

Description (last modified by kzar)

Background

messageResponder.js contains a rather monolithic message listener, still using the ext API which is planned to go away.

What to change

Break the message listener down into separate listeners which use the Port API. (See adblockpluschrome/lib/messaging.js.)

While at it we might as well update the file to use more modern JavaScript syntax like let instead of var, arrow functions and for of. We also might as well remove the code for Safari support which is no longer needed.

Attachments (0)

Change History (6)

comment:1 Changed on 01/10/2017 at 08:00:07 AM by kzar

  • Description modified (diff)

comment:2 Changed on 01/11/2017 at 08:52:32 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/12/2017 at 09:59:19 AM by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:5 Changed on 01/19/2017 at 04:05:01 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 01/19/2017 at 04:16:23 AM by kzar

  • Blocking 4823 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.