Opened on 01/17/2017 at 02:49:31 PM

Last modified on 03/13/2018 at 01:34:02 PM

#4811 new change

Cleanup for branch "tame isolates and threads".

Reported by: eric@adblockplus.org Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: sergz, oleksandr Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by eric@adblockplus.org)

Background

The libadblockplus branch "tame isolates and threads" is being reviewed as a branch. This issue tracks style and efficiency concerns that will be handled at the end of the process.

What to change

  • Close issues fixed only on branch: #4711

Attachments (0)

Change History (5)

comment:1 Changed on 01/17/2017 at 03:24:41 PM by eric@adblockplus.org

  • Cc sergz added

comment:2 Changed on 01/17/2017 at 03:29:12 PM by eric@adblockplus.org

  • Description modified (diff)

comment:3 follow-up: Changed on 11/18/2017 at 06:15:42 AM by oleksandr

  • Cc oleksandr added

With #4711 closed now and there aren't any style and efficiency concerns this can be closed now?

comment:4 in reply to: ↑ 3 Changed on 11/18/2017 at 01:55:51 PM by sergz

Replying to oleksandr:

With #4711 closed now and there aren't any style and efficiency concerns this can be closed now?

Firstly let's close the branch "tame threads and isolates" and then this issue.

comment:5 Changed on 03/13/2018 at 01:34:02 PM by sergz

I could not imaging that closing of a branch can be so non-trivial, ​https://stackoverflow.com/questions/3227988/closing-hg-branches

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.