Opened on 01/18/2017 at 10:03:54 AM
Closed on 02/07/2017 at 04:35:15 PM
Last modified on 02/14/2017 at 07:51:58 PM
#4817 closed change (fixed)
Update committee application form on acceptableads.com
| Reported by: | jobp | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | vickyyu, saroyanm, innerself, athornburgh, lisabielik | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Background
As part of #4843 we would like to update the following on the Acceptable Ads committee form.
What to change
- Add Ad-blocker user option to Stakeholder group select
- Change Consumer Group option to Digital Rights Organization select
- Change the page title to Apply to join the committee
- Replace the two paragraphs at the top of the page with the following text
Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!
Attachments (1)
Change History (29)
comment:1 Changed on 01/25/2017 at 08:36:20 PM by juliandoucette
- Cc saroyanm added
- Priority changed from Unknown to P1
- Ready set
comment:3 Changed on 01/30/2017 at 11:05:02 AM by juliandoucette
- Priority changed from P1 to P2
comment:4 Changed on 01/31/2017 at 12:25:27 PM by saroyanm
- Blocking 4843 added
comment:5 Changed on 01/31/2017 at 07:46:41 PM by saroyanm
- Summary changed from Add a new "Stakeholder group" to the application form on https://acceptableads.com/en/committee/apply to Add a new "Stakeholder group" on Apply for committee page
Note: make sense to check the backend implementation first -> https://issues.adblockplus.org/ticket/4377
comment:6 Changed on 02/01/2017 at 12:13:36 PM by saroyanm
- Cc innerself athornburgh added
- Description modified (diff)
comment:7 Changed on 02/01/2017 at 01:34:12 PM by juliandoucette
- Owner set to juliandoucette
comment:8 Changed on 02/01/2017 at 02:48:44 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Summary changed from Add a new "Stakeholder group" on Apply for committee page to Update committee application form on acceptableads.com
@athornburgh You tacked on extra requirements to "what to change" that made the summary invalid.
Can we push this entire change asap?
comment:9 in reply to: ↑ description ; follow-up: ↓ 10 Changed on 02/01/2017 at 03:54:18 PM by saroyanm
- Cc lisabielik added
Replying to jobp:
Background
To accurately reflect the last changes in the bylaws since September, a seat will be awarded to an adblocking user. This option should be added to the dropdown menu on https://acceptableads.com/en/committee/apply
What to change
On the application form on https://acceptableads.com/en/committee/apply, please change the following:
- Under the "Stakeholder group" dropdown:
- Add a category for "Ad blocker user"
Adblocker user instead of Ad blocker user
@lisa @job: can you please confirm that the ticket text is correct ?
comment:10 in reply to: ↑ 9 Changed on 02/01/2017 at 06:47:41 PM by lisabielik
Replying to saroyanm:
Replying to jobp:
Background
To accurately reflect the last changes in the bylaws since September, a seat will be awarded to an adblocking user. This option should be added to the dropdown menu on https://acceptableads.com/en/committee/apply
What to change
On the application form on https://acceptableads.com/en/committee/apply, please change the following:
- Under the "Stakeholder group" dropdown:
- Add a category for "Ad blocker user"
Adblocker user instead of Ad blocker user
@lisa @job: can you please confirm that the ticket text is correct ?
It should be Ad-blocker user
comment:11 Changed on 02/01/2017 at 09:48:56 PM by juliandoucette
@lisa can you confirm that the rest of the text (that was added and that which remains) is correct?
comment:12 follow-up: ↓ 14 Changed on 02/01/2017 at 09:51:09 PM by juliandoucette
- Description modified (diff)
Who can confirm that what we send to the backend is correct?
(Can we send any option value, or does someone have to configure it first?)
comment:13 Changed on 02/01/2017 at 11:13:53 PM by jobp
LGTM
comment:14 in reply to: ↑ 12 Changed on 02/02/2017 at 10:53:11 AM by saroyanm
Replying to juliandoucette:
Who can confirm that what we send to the backend is correct?
(Can we send any option value, or does someone have to configure it first?)
Check my comment here, I had a quick look through sitescript implementation, seems like we are fine here, what ever new option we will add into that selectbox the value will be sent to the email.
Anyway after pushing the changes, make sense to ask Job to test, to be 100% sure.
comment:15 Changed on 02/05/2017 at 04:53:04 PM by juliandoucette
- Priority changed from P2 to Unknown
- Ready unset
- Sorry athornburgh, it was saroyanm that tacked on the extra requirements not you
- saroyanm you forgot to update ready, summary, and description -> background after you changed description -> what to change
- Lisa can you please review the contents of this ticket again?
- And LGTM when it's approved
comment:16 Changed on 02/06/2017 at 03:04:55 PM by jobp
Anything I can do to move this forward? We are pushing the press release out today / tomorrow - would be nice to have the form updated by then.
comment:17 follow-up: ↓ 18 Changed on 02/06/2017 at 10:32:33 PM by juliandoucette
@lisabielik has to re-LGTM the content or @athornburgh has to approve us pushing this change temporarily without @lisabielik's approval. And then @saroyanm has to LGTM the code review.
comment:18 in reply to: ↑ 17 Changed on 02/06/2017 at 11:37:17 PM by lisabielik
Replying to juliandoucette:
@lisabielik has to re-LGTM the content or @athornburgh has to approve us pushing this change temporarily without @lisabielik's approval. And then @saroyanm has to LGTM the code review.
@juliandoucette:
The text on this page should read:
Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!
comment:19 Changed on 02/07/2017 at 10:11:33 AM by juliandoucette
- Description modified (diff)
- Ready set
comment:20 Changed on 02/07/2017 at 10:16:26 AM by juliandoucette
- Ready unset
@lisabielik I think that makes the page title redundant doesn't it?
Page title: Want to join the Acceptable Ads Committee? Fill out the form below!
Paragraph 1: Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!
(I will attach a screenshot)
Changed on 02/07/2017 at 10:17:01 AM by juliandoucette
comment:21 Changed on 02/07/2017 at 10:50:51 AM by juliandoucette
- Description modified (diff)
I just checked the wireframes again and found a different title. I'm going to go out on a limb and say that someone forgot to add this to the ticket spec and add it myself + update the code review.
Aaron or Lisa can you please confirm?
Thanks! :)
comment:22 Changed on 02/07/2017 at 12:34:59 PM by athornburgh
The page title should be:
"Apply to join the committee"
comment:23 Changed on 02/07/2017 at 12:36:41 PM by athornburgh
I approve all other content changes.
comment:24 Changed on 02/07/2017 at 12:48:18 PM by juliandoucette
- Ready set
comment:25 Changed on 02/07/2017 at 04:34:15 PM by abpbot
A commit referencing this issue has landed:
Issue 4817 - Updated AAC form with new headdline, summary, and stakeholder options
comment:26 Changed on 02/07/2017 at 04:35:15 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
comment:27 Changed on 02/14/2017 at 05:01:35 PM by juliandoucette
- Blocking 4843 removed
- Milestone set to acceptableads.com/committee 160301
comment:28 Changed on 02/14/2017 at 07:51:58 PM by juliandoucette
- Milestone acceptableads.com/committee 160301 deleted
@jobp: I think this is time sensitive. Hence P1. Please correct me if I am wrong.