Opened on 01/19/2017 at 03:55:30 PM

Closed on 02/21/2017 at 12:45:29 PM

#4825 closed change (fixed)

Let ElemHideEmulation associate selector and filter

Reported by: wspee Assignee:
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #3596 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29372676/

Description (last modified by wspee)

Background

For #3596 to work we need to now for which element hiding emulation filter a hiding selector was created.

What to change

Let ElemHideEmulation pass not only the hiding styles but also the corresponding element hiding emulation filter when calling addSelectorsFunc.

Attachments (0)

Change History (4)

comment:1 Changed on 01/19/2017 at 04:21:44 PM by wspee

  • Review URL(s) modified (diff)

comment:2 Changed on 02/18/2017 at 11:14:47 AM by wspee

  • Description modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 02/21/2017 at 12:32:31 PM by abpbot

A commit referencing this issue has landed:
​Issue 4825 - Let ElemHideEmulation associate selector and filter when calling addSelectorsFunc

comment:4 Changed on 02/21/2017 at 12:45:29 PM by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.