Opened on 05/14/2014 at 10:57:30 AM
Closed on 11/10/2017 at 11:15:18 AM
#483 closed change (rejected)
Evaluate replacing Utils.makeURI() and Services.io.newURI() by URL constructor
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
We are currently using Services.io.newURI() and occasionally Utils.makeURI() to construct nsIURI instances. As of Firefox 19 the URL constructor is a faster and simpler alternative. It is also available in Chrome but unfortunately not in Safari yet (Safari will happily construct URL objects but not provide any properties on them whatsoever).
What to change
Evaluate where in our code base we can use URL constructor. I guess that it won't be possible anywhere where XPCOM is involved: URL doesn't seem to implement the nsIURI interface. Also, it won't be possible when we verify website signatures: we need nsIURI.asciiHost to get the Punycode-encoded value. Filter composer should be able to use URL however, Subscription constructor and other places validating URLs probably as well.
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.