Opened on 02/01/2017 at 01:07:01 PM
Closed on 07/31/2019 at 05:19:31 PM
#4856 closed change (duplicate)
Reimplement getDocLink assignment in adblockplusUI
| Reported by: | saroyanm | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
We do use getDocLink function to assign redirectable, localized links. Usage of that function, both in new-options.js and firstRun.js is messy and inefficient due to unnecessary repetition.
What to change
Use the data-doclink attribute to assign links that use adblockplus.org/redirect to anchor tags on the page (similar to data-i18n).
Note that as soon as the messaging API supports it, we could make use of the initialization code to aggregate all "app.get" messages into a single one to avoid unnecessary message passing.
Attachments (0)
Change History (3)
comment:1 Changed on 02/01/2017 at 01:16:54 PM by saroyanm
- Description modified (diff)
comment:2 Changed on 02/02/2017 at 12:50:59 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
I'm fine with the proposed changes but I'd suggest tackling the efficiency issue separately. The reason for that being that multiple input and output values were initially part of the messaging protocol but got rejected. Therefore we first need to agree on an appropriate way on how we can minimize the communication overhead between background page and other pages - requesting multiple values at once is only one possible approach.
I created this as a part of current discussion: