Opened on 02/06/2017 at 03:00:32 PM

Closed on 02/09/2017 at 04:21:08 PM

#4865 closed change (fixed)

Make sure Identity.Name attribute is different for development builds for Edge

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29374642/

Description

Background

We have added a packager for Microsoft Edge in #4028. Unfortunately it did not account for a different Identity.Name for development builds.

What to change

Identity.Name should remain EyeoGmbH.AdblockPlus for release builds, but for development builds it should be EyeoGmbH.AdblockPlusdevelopmentbuild

Attachments (0)

Change History (3)

comment:1 Changed on 02/06/2017 at 10:45:17 PM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 02/09/2017 at 04:05:57 PM by abpbot

A commit referencing this issue has landed:
​Issue 4865 - Make sure Identity.Name attribute is different for devbuilds for Edge

comment:3 Changed on 02/09/2017 at 04:21:08 PM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.