Opened on 02/08/2017 at 06:36:03 AM

Closed on 03/16/2017 at 08:28:10 AM

Last modified on 03/21/2017 at 09:48:20 AM

#4871 closed change (fixed)

Start using ESLint for adblockplusui repository

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By: #3692
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29375899/

Description (last modified by kzar)

Background

With #3692 we're adding a base ESLint configuration to the buildtools repository. Once that is finished we want to start using the configuration for the adblockplusui repository.

What to change

  • Update the buildtools dependency to include the ESLint configuration.
  • Add an ESLint configuration to adblockplusui which inherits from it:
    {
      "extends": "./buildtools/.eslintrc.json",
      "root": true,
      ...
    }
    
  • Make the necessary changes so that linting passes.
  • Add a note in the README explaining how to lint the code (eslint *.js lib ext).

Attachments (0)

Change History (11)

comment:1 Changed on 02/08/2017 at 06:37:11 AM by kzar

(Blocking #4864 since the way we're declaring the ext variable in messageResponder.js breaks when we start using let for the variable in the adblockpluschrome code.)

comment:2 Changed on 02/08/2017 at 07:34:05 AM by kzar

  • Description modified (diff)

comment:3 Changed on 02/08/2017 at 07:50:10 AM by kzar

  • Description modified (diff)

comment:4 Changed on 02/08/2017 at 08:41:48 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

(The changes required for all adblockplusui code to pass are absolutely huge, so I've started off with the messageResponder which is what's blocking #4864.)

comment:5 Changed on 02/08/2017 at 09:04:51 AM by kzar

  • Blocking 4864 removed

comment:6 Changed on 02/08/2017 at 09:54:38 AM by kzar

  • Description modified (diff)

comment:7 Changed on 02/08/2017 at 09:58:45 AM by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:8 Changed on 03/02/2017 at 07:16:09 PM by greiner

See also #4801

comment:9 Changed on 03/16/2017 at 08:24:27 AM by abpbot

A commit referencing this issue has landed:
Issue 4871 - Start using ESLint for adblockplusui

comment:10 Changed on 03/16/2017 at 08:28:10 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 03/21/2017 at 09:48:20 AM by sebastian

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.