Opened on 02/16/2017 at 11:37:26 AM

Closed on 03/17/2017 at 08:27:06 PM

#4903 closed change (fixed)

Allow to specify file system root

Reported by: asmirnov Assignee: asmirnov
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29375826/

Description

Background

By default 'AdblockHelper' uses app cache dir (context.getCacheDir()) as file system root. This may be not desired as it can be cleared by the system.

What to change

We need to provide path argument to be more flexible.
It would be better not to break back compatibility.

Attachments (0)

Change History (4)

comment:1 Changed on 02/16/2017 at 11:44:51 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/02/2017 at 08:12:07 AM by asmirnov

  • Priority changed from P3 to P2

comment:3 Changed on 03/17/2017 at 08:25:36 PM by abpbot

A commit referencing this issue has landed:
​Issue 4903 - Allow to specify file system root

comment:4 Changed on 03/17/2017 at 08:27:06 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from asmirnov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.