Opened on 02/27/2017 at 10:18:43 AM

Closed on 07/27/2017 at 02:17:57 PM

#4937 closed defect (fixed)

Unit tests have race conditions because we are not waiting for initialized state

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #4938 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

adblockpluscore triggers many events during initialization and we are not waiting for finishing of the initialization. E.g. in FilterEngineTest, SetRemoveFilterChangeCallback sometimes we count also "load" event from FilterNotifier and the test fails because the actual number of calls is 2 but 1 is expected.

Attachments (0)

Change History (4)

comment:1 Changed on 02/27/2017 at 10:22:43 AM by sergz

  • Blocked By 4938 added

comment:2 Changed on 02/27/2017 at 10:34:06 AM by sergz

  • Blocked By 4938 removed

comment:3 Changed on 02/27/2017 at 10:38:25 AM by sergz

  • Blocking 4938 added

comment:4 Changed on 07/27/2017 at 02:17:57 PM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.