Opened on 03/13/2017 at 05:55:43 AM

Closed on 03/28/2017 at 10:07:57 AM

#4977 closed change (fixed)

Request for compressed response in AndroidWebRequest

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29382555/

Description (last modified by asmirnov)

Background

In order to save traffic and loading time we can request for 'gzip'ped stream from the server.
Related issue #4916

What to change

Change AndroidWebRequest class to request/return compressed stream from the server.

Attachments (2)

Снимок экрана 2017-03-13 в 11.37.29.png (435.0 KB) - added by asmirnov on 03/13/2017 at 07:07:41 AM.
gzip
Снимок экрана 2017-03-13 в 11.40.20.png (455.9 KB) - added by asmirnov on 03/13/2017 at 07:08:05 AM.
identity

Download all attachments as: .zip

Change History (9)

comment:1 Changed on 03/13/2017 at 05:57:08 AM by asmirnov

  • Description modified (diff)

comment:2 Changed on 03/13/2017 at 06:10:29 AM by asmirnov

As reported in Google blog (https://android-developers.googleblog.com/2011/09/androids-http-clients.html) gzip compression is requested by default and handled automatically:

In Gingerbread, we added transparent response compression. HttpURLConnection will automatically add this header to outgoing requests, and handle the corresponding response:

Accept-Encoding: gzip

Take advantage of this by configuring your Web server to compress responses for clients that can support it. If response compression is problematic, the class documentation shows how to disable it.

but i've seen some feedbacks that it's not done automatically for http:// requests. To be checked.

comment:3 Changed on 03/13/2017 at 07:04:13 AM by asmirnov

  • Summary changed from Request for compressed response in WebRequest to Request for compressed response in AndroidWebRequest

comment:4 Changed on 03/13/2017 at 07:04:28 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 03/13/2017 at 07:05:47 AM by asmirnov

Changed on 03/13/2017 at 07:07:41 AM by asmirnov

gzip

Changed on 03/13/2017 at 07:08:05 AM by asmirnov

identity

comment:6 Changed on 03/28/2017 at 10:06:08 AM by abpbot

A commit referencing this issue has landed:
Issue 4977 - Request for compressed response in AndroidWebRequest

comment:7 Changed on 03/28/2017 at 10:07:57 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.